Add LD2410 BLE integration by 930913 · Pull Request #83883 · home-assistant/core

930913 · 2022-12-12T23:27:27Z

Proposed change

Adds an MVP integration to connect to LD2410B sensors over bluetooth. This was the mmWave sensor demonstrated by Andreas Spiess at https://www.youtube.com/watch?v=dAzHXpP3FcI

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

Link to documentation pull request: Add LD2410 BLE integration home-assistant.io#25264

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[n/a] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2022-12-12T23:27:30Z

Hi 930913

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

- Add integration - Add config flow - Add binary_sensor - Add tests - Update CODEOWNERS

- Add return types - Raise errors from previous error - Rm unneeded log

Add type notation to missing places in binary_sensor

update -> initialise

- Use BinarySensorEntityDescription - Remove lokalized languages - Remove dupe async_add_entities call

Also catch all BleakError

And don't concatenate f strings.

s/led/ld2410/

Use the entity description to get the key

Track connectivity on the coordinator and return availiblity accordingly.

Forgot to add it, lol.

TODO: Tests

bdraco · 2022-12-15T07:08:30Z

This looks like its pretty close to ready. I just need to find time to do another review pass after I've had enough sleep to be sure 😄

930913 · 2022-12-19T00:07:55Z

This looks like its pretty close to ready. I just need to find time to do another review pass after I've had enough sleep to be sure smile

@bdraco How has your sleeping been? 😆

bdraco · 2022-12-19T00:37:27Z

Not as well as I had hoped. This is still on my list to get done

bdraco · 2022-12-19T22:09:26Z

+ENTITY_DESCRIPTIONS = [
+    BinarySensorEntityDescription(
+        key="is_moving",
+        device_class=BinarySensorDeviceClass.MOTION,
+        has_entity_name=True,
+        name="Motion",
+    ),
+    BinarySensorEntityDescription(
+        key="is_static",
+        device_class=BinarySensorDeviceClass.OCCUPANCY,
+        has_entity_name=True,
+        name="Occupancy",
+    ),
+]


MINOR: This could be a tuple since it never changes

Noted. I might change it in a subsequent MR.

bdraco

LGTM 👍

bdraco · 2022-12-19T22:12:02Z

Looks like there is some feedback on the docs PR to address: home-assistant/home-assistant.io#25264

home-assistant Bot added cla-needed new-integration integration: ld2410_ble labels Dec 12, 2022

home-assistant Bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Dec 12, 2022

930913 mentioned this pull request Dec 12, 2022

Add LD2410 BLE integration home-assistant/home-assistant.io#25264

Merged

8 tasks

930913 added 4 commits December 13, 2022 16:08

Add LD2410 BLE integration

ff023f3

- Add integration - Add config flow - Add binary_sensor - Add tests - Update CODEOWNERS

Fix pylint

963f907

- Add return types - Raise errors from previous error - Rm unneeded log

Fix types

d5c26ca

Add type notation to missing places in binary_sensor

Fix typos

7e4cf3b

update -> initialise

930913 force-pushed the add_ld2410_ble_integration branch from af67cba to 7e4cf3b Compare December 13, 2022 16:09

930913 mentioned this pull request Dec 13, 2022

Add assets for LD2410 BLE integration home-assistant/brands#3925

Merged

9 tasks

930913 marked this pull request as ready for review December 13, 2022 16:41

bdraco reviewed Dec 13, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py

bdraco reviewed Dec 13, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

bdraco reviewed Dec 13, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/translations/ca.json Outdated

Use BinarySensorEntityDescription

534af31

- Use BinarySensorEntityDescription - Remove lokalized languages - Remove dupe async_add_entities call

930913 requested a review from bdraco December 13, 2022 23:34

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/__init__.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

Refactor to one class

17be51f

Also catch all BleakError

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/__init__.py Outdated

Comprehend sensors

a34fbda

And don't concatenate f strings.

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/binary_sensor.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/const.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/const.py Outdated

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/manifest.json Outdated

930913 added 5 commits December 14, 2022 11:43

Fix manifest.documentation

5322f85

s/led/ld2410/

Remove unused constants

34e4a6b

Pack entity description

6162fe8

Use the entity description to get the key

Refactor availibility

4cf70b6

Track connectivity on the coordinator and return availiblity accordingly.

Add coordinator file

af869ca

Forgot to add it, lol.

bdraco reviewed Dec 14, 2022

View reviewed changes

Comment thread homeassistant/components/ld2410_ble/manifest.json

Add coordinator file to coverage exclusion

f41a846

TODO: Tests

bdraco self-requested a review December 19, 2022 00:41

bdraco reviewed Dec 19, 2022

View reviewed changes

bdraco approved these changes Dec 19, 2022

View reviewed changes

bdraco approved these changes Jan 6, 2023

View reviewed changes

bdraco merged commit 2507ec1 into home-assistant:dev Jan 6, 2023

cgarwood mentioned this pull request Jan 6, 2023

Bump bluetooth-data-tools to 0.3.1 for ld2410-ble #85278

Merged

19 tasks

github-actions Bot locked and limited conversation to collaborators Jan 7, 2023

Uh oh!

Conversation

930913 commented Dec 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented Dec 12, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bdraco commented Dec 15, 2022

Uh oh!

930913 commented Dec 19, 2022

Uh oh!

bdraco commented Dec 19, 2022

Uh oh!

bdraco Dec 19, 2022

Choose a reason for hiding this comment

Uh oh!

930913 Jan 6, 2023

Choose a reason for hiding this comment

Uh oh!

bdraco left a comment

Choose a reason for hiding this comment

Uh oh!

bdraco commented Dec 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

930913 commented Dec 12, 2022 •

edited

Loading