Skip to content

Implement ConfigEntry async_wait_for_states#81771

Merged
jbouwh merged 3 commits into
home-assistant:devfrom
jbouwh:wait-for-states
Nov 8, 2022
Merged

Implement ConfigEntry async_wait_for_states#81771
jbouwh merged 3 commits into
home-assistant:devfrom
jbouwh:wait-for-states

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented Nov 8, 2022

Proposed change

When an integration has a dependency, then async_setup is awaited, this does not assure the config entry is loaded. This PR adds a function to support awaiting a state change of the entry while loading.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Comment thread tests/test_config_entries.py Outdated
@jbouwh jbouwh closed this Nov 8, 2022
@jbouwh jbouwh reopened this Nov 8, 2022
@jbouwh jbouwh merged commit 3cc9ecf into home-assistant:dev Nov 8, 2022
@jbouwh jbouwh deleted the wait-for-states branch November 8, 2022 16:18
Comment thread tests/test_config_entries.py
Comment thread tests/test_config_entries.py
Comment thread tests/test_config_entries.py
jbouwh added a commit to jbouwh/core that referenced this pull request Nov 8, 2022
MartinHjelmare pushed a commit that referenced this pull request Nov 8, 2022
* Late review on tests #81771

* Clean-up duplicate assignment
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants