Skip to content

Wait for MQTT entry on snips integration startup#81733

Merged
jbouwh merged 1 commit into
home-assistant:devfrom
jbouwh:snips-mqtt-not-set-up
Nov 20, 2022
Merged

Wait for MQTT entry on snips integration startup#81733
jbouwh merged 1 commit into
home-assistant:devfrom
jbouwh:snips-mqtt-not-set-up

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented Nov 7, 2022

Proposed change

Wait for MQTT entry to set up before the snips integration is set up.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Comment thread homeassistant/components/snips/__init__.py Outdated
@jbouwh jbouwh marked this pull request as draft November 7, 2022 17:47
Comment thread homeassistant/components/snips/__init__.py Outdated
@jbouwh jbouwh marked this pull request as ready for review November 7, 2022 19:08
@jbouwh jbouwh requested a review from emontnemery as a code owner November 7, 2022 19:08
Comment thread homeassistant/components/snips/__init__.py Outdated
@jbouwh jbouwh marked this pull request as draft November 7, 2022 19:24
Comment thread homeassistant/config_entries.py Outdated
@jbouwh
Copy link
Copy Markdown
Contributor Author

jbouwh commented Nov 8, 2022

@bdraco I have opened #81771 in advance.

@jbouwh jbouwh force-pushed the snips-mqtt-not-set-up branch from 2196cc1 to 4be4340 Compare November 8, 2022 16:30
@jbouwh jbouwh marked this pull request as ready for review November 8, 2022 16:31
@jbouwh jbouwh added this to the 2022.11.3 milestone Nov 8, 2022
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 8, 2022

Unless we plan on tagging the config entry change for .3 I don't think we can tag this one

@jbouwh jbouwh removed this from the 2022.11.3 milestone Nov 8, 2022
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Nov 9, 2022

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the issue, add the integration domain after the command.

@jbouwh jbouwh force-pushed the snips-mqtt-not-set-up branch 2 times, most recently from aa31cc6 to 608801a Compare November 11, 2022 19:47
@jbouwh jbouwh marked this pull request as draft November 14, 2022 13:08
@jbouwh jbouwh force-pushed the snips-mqtt-not-set-up branch from 608801a to cff2812 Compare November 18, 2022 09:37
@jbouwh jbouwh changed the title Fix startup snips integration without MQTT Wait for MQTT entry on snips integration startup Nov 18, 2022
@jbouwh jbouwh marked this pull request as ready for review November 18, 2022 09:56
@jbouwh jbouwh added smash Indicator this PR is close to finish for merging or closing and removed has-tests labels Nov 18, 2022
@jbouwh jbouwh added this to the 2022.11.4 milestone Nov 18, 2022
@jbouwh jbouwh force-pushed the snips-mqtt-not-set-up branch from 707a727 to e55af14 Compare November 19, 2022 18:25
@jbouwh jbouwh force-pushed the snips-mqtt-not-set-up branch from e55af14 to 1623b13 Compare November 19, 2022 18:26
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 20, 2022

#76980 isn't tagged for .4 so I don't think we can tag this one unless we want to add that one as well.

@jbouwh jbouwh removed this from the 2022.11.4 milestone Nov 20, 2022
@jbouwh
Copy link
Copy Markdown
Contributor Author

jbouwh commented Nov 20, 2022

#76980 isn't tagged for .4 so I don't think we can tag this one unless we want to add that one as well.

I'll remove the tag for .4. In that case it must wait till 2022.12.0

@jbouwh jbouwh merged commit 5c00b8b into home-assistant:dev Nov 20, 2022
@jbouwh jbouwh deleted the snips-mqtt-not-set-up branch November 20, 2022 15:17
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cla-signed integration: mqtt integration: snips Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Component Snips can’t subscribe to MQTT at startup

5 participants