Wait for MQTT entry on snips integration startup#81733
Merged
Merged
Conversation
Rudd-O
reviewed
Nov 7, 2022
akx
reviewed
Nov 7, 2022
Rudd-O
approved these changes
Nov 7, 2022
bdraco
reviewed
Nov 7, 2022
Contributor
Author
2196cc1 to
4be4340
Compare
Member
|
Unless we plan on tagging the config entry change for .3 I don't think we can tag this one |
Contributor
|
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
aa31cc6 to
608801a
Compare
608801a to
cff2812
Compare
707a727 to
e55af14
Compare
e55af14 to
1623b13
Compare
Member
|
#76980 isn't tagged for .4 so I don't think we can tag this one unless we want to add that one as well. |
Contributor
Author
I'll remove the tag for .4. In that case it must wait till 2022.12.0 |
bdraco
approved these changes
Nov 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Wait for MQTT entry to set up before the
snipsintegration is set up.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: