Fix Push notifications subscription expiration/removal#7761
Closed
hoh wants to merge 10 commits into
Closed
Conversation
* bugfix for Telegram chat_ids - Negative `chat_id`s for groups. - Include `chat_id` in event data. - Handle KeyError when receiving other types of messages, as `new_chat_member` ones, and send them as text. * unused import * fix double quote style, fix boolean expr, change warning msg * mistake * some more fixes - fix if condition for msg bad fields. - return True for a correct but not allowed or not recognized message: if not, the message arrives continuously. - Allow to receive messages from unauthorized users if they come from authorized groups. * support for `edited_message`s - They come as normal messages, except for the 'edited_message' field instead of 'message'.
Web streams can't be paused and resumed later. That's why volumio stops them instead of pausing them.
If OpenWRT isn't running the DHCP server then some OpenWRT hardware, such as TP-Link TL-WDR3600 v1, can't determine the host corresponding to an associated wifi client. This change handles that by returning None when the request has no data in the result.
Removes a subscription after receiving an HTTP 410 response when trying to send a new message.
houndci-bot
reviewed
May 25, 2017
| self.registrations[target] = reg | ||
| _LOGGER.error("Error saving registration.") | ||
| else: | ||
| _LOGGER.info("Configuration saved") No newline at end of file |
| if (response.status_code == 410): | ||
| _LOGGER.info("Notification channel has expired") | ||
| reg = self.registrations.pop(target) | ||
| if not _save_config(self.registrations_json_path, self.registrations): |
There was a problem hiding this comment.
line too long (86 > 79 characters)
Member
|
It looks like you branched off master. Could you rebase off dev? |
Member
|
I have cherry-picked your commits into a new PR: #7874 Thanks for your contribution 👍 |
ghost
added
integration: html5
integration: state
integration: telegram
integration: ubus
integration: volumio
and removed
platform: media_player.volumio
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue: fixes #7758
Example entry for
configuration.yaml(if applicable):Checklist:
If the code communicates with devices, web services, or third-party tools:
py.testrun successfully.