Skip to content

Fix playback control of web streams in volumio component#7683

Merged
balloob merged 1 commit into
home-assistant:devfrom
cgtobi:patch-1
May 22, 2017
Merged

Fix playback control of web streams in volumio component#7683
balloob merged 1 commit into
home-assistant:devfrom
cgtobi:patch-1

Conversation

@cgtobi
Copy link
Copy Markdown
Contributor

@cgtobi cgtobi commented May 20, 2017

Web streams can't be paused and resumed later. That's why volumio stops them instead of pausing them. This change reflects this behavior.

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Web streams can't be paused and resumed later. That's why volumio stops them instead of pausing them.
@mention-bot
Copy link
Copy Markdown

@cgtobi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jslove, @fabaff and @balloob to be potential reviewers.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @cgtobi,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@jslove
Copy link
Copy Markdown
Contributor

jslove commented May 20, 2017

This works for me.

@balloob balloob added this to the 0.45.1 milestone May 22, 2017
@balloob balloob merged commit b3cb057 into home-assistant:dev May 22, 2017
@cgtobi cgtobi deleted the patch-1 branch May 22, 2017 05:16
balloob pushed a commit that referenced this pull request May 22, 2017
Web streams can't be paused and resumed later. That's why volumio stops them instead of pausing them.
@balloob balloob mentioned this pull request May 22, 2017
@balloob balloob mentioned this pull request Jun 2, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Sep 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants