Skip to content

Add QNAP QSW sensors for each port#76811

Merged
bdraco merged 5 commits into
home-assistant:devfrom
Noltari:qnap-qsw-port-sensors
Jan 7, 2023
Merged

Add QNAP QSW sensors for each port#76811
bdraco merged 5 commits into
home-assistant:devfrom
Noltari:qnap-qsw-port-sensors

Conversation

@Noltari
Copy link
Copy Markdown
Contributor

@Noltari Noltari commented Aug 15, 2022 •
edited
Loading

Proposed change

Add QNAP QSW binary sensors for each port.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 14, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Sep 14, 2022
@Noltari
Copy link
Copy Markdown
Contributor Author

Noltari commented Sep 21, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

Not stale

@github-actions github-actions Bot removed the stale label Sep 21, 2022
@Noltari Noltari force-pushed the qnap-qsw-port-sensors branch from 54bc752 to db713bc Compare November 28, 2022 18:49
@Noltari
Copy link
Copy Markdown
Contributor Author

Noltari commented Nov 28, 2022

Rebased on top of #76522 873b903
Added changes suggested by @bdraco and @balloob for binary sensors.

@Noltari Noltari marked this pull request as ready for review November 28, 2022 18:51
bdraco
bdraco reviewed Dec 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

@Noltari
qnap_qsw: add individual port sensors
19ca059 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari force-pushed the qnap-qsw-port-sensors branch from b818e13 to 19ca059 Compare December 12, 2022 12:24
@Noltari
Copy link
Copy Markdown
Contributor Author

Noltari commented Dec 12, 2022

Please resolve conflicts

Should be fixed now @bdraco
codecov/patch failure isn't related to changes.

@Noltari Noltari requested a review from bdraco December 13, 2022 08:19
bdraco
bdraco reviewed Jan 3, 2023
View reviewed changes
Comment thread homeassistant/components/qnap_qsw/sensor.py
bdraco
bdraco reviewed Jan 3, 2023
View reviewed changes
Comment thread homeassistant/components/qnap_qsw/sensor.py
Noltari added 2 commits January 4, 2023 15:30
@Noltari
qnap_qsw: sensor: switch DATA_BYTES to UnitOfInformation
1f9703d 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari
qnap_qsw: sensor: improve readability
ee03a03 
Introduces changes suggested by @bdraco to improve readability and reduce
indentation.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari requested a review from bdraco January 4, 2023 14:43
@Noltari
Copy link
Copy Markdown
Contributor Author

Noltari commented Jan 5, 2023 •
edited
Loading

odecov/patch failure isn't related to changes.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jan 5, 2023 •
edited
Loading

Are there any docs that need to be updated for this?

@Noltari
Copy link
Copy Markdown
Contributor Author

Noltari commented Jan 5, 2023

Are there any docs that need to be updated for this?

I guess I can add the new port sensors to the existing sensors section...
https://www.home-assistant.io/integrations/qnap_qsw#sensors

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Jan 5, 2023

Should be good to merge once docs PR is open

@Noltari Noltari mentioned this pull request Jan 7, 2023
Merged
8 tasks
@Noltari
Copy link
Copy Markdown
Contributor Author

Noltari commented Jan 7, 2023

Should be good to merge once docs PR is open

Docs PR created: home-assistant/home-assistant.io#25621

@bdraco bdraco merged commit 3a905f8 into home-assistant:dev Jan 7, 2023
@Noltari Noltari deleted the qnap-qsw-port-sensors branch January 7, 2023 20:49
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bdraco bdraco bdraco approved these changes

Assignees

No one assigned

Labels

by-code-owner cla-signed has-tests integration: qnap_qsw new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Noltari @bdraco @homeassistant