Skip to content

Add QNAP QSW binary sensors for each port#76522

Merged
balloob merged 6 commits into
home-assistant:devfrom
Noltari:qnap-qsw-port-binary-sensor
Nov 27, 2022
Merged

Add QNAP QSW binary sensors for each port#76522
balloob merged 6 commits into
home-assistant:devfrom
Noltari:qnap-qsw-port-binary-sensor

Conversation

@Noltari
Copy link
Copy Markdown
Contributor

@Noltari Noltari commented Aug 9, 2022

Proposed change

Add QNAP QSW binary sensors for each port.
These binary sensors are disabled by default, but the intention is to provide the user the ability to track specific port (dis)connections.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari mentioned this pull request Aug 15, 2022
23 tasks
Comment thread homeassistant/components/qnap_qsw/binary_sensor.py Outdated
@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Aug 29, 2022
(as requested by @bdraco)

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Comment thread homeassistant/components/qnap_qsw/binary_sensor.py Outdated
bdraco and others added 2 commits November 17, 2022 12:42
@Noltari Noltari requested review from balloob and bdraco and removed request for balloob and bdraco November 17, 2022 20:53
@balloob balloob merged commit 873b903 into home-assistant:dev Nov 27, 2022
@Noltari Noltari deleted the qnap-qsw-port-binary-sensor branch November 28, 2022 14:11
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed has-tests integration: qnap_qsw new-feature smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants