Skip to content

Make miflora monitored_conditions parameter optional #7598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 4 commits into from
May 16, 2017
Merged

Make miflora monitored_conditions parameter optional #7598

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82258ca
Make miflora monitored_conditions parameter optional.
frog32 May 14, 2017
77e7808
Use default keyword instead.
frog32 May 15, 2017
4ae104f
Use list instead of tuple
frog32 May 15, 2017
ad7d561
Simplify even more
balloob May 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions homeassistant/components/sensor/miflora.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({
vol.Required(CONF_MAC): cv.string,
vol.Required(CONF_MONITORED_CONDITIONS):
vol.Optional(CONF_MONITORED_CONDITIONS):

@balloob balloob May 15, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the default keyword for vol.Optional instead

vol.All(cv.ensure_list, [vol.In(SENSOR_TYPES)]),
vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string,
vol.Optional(CONF_MEDIAN, default=DEFAULT_MEDIAN): cv.positive_int,
Expand All @@ -72,7 +72,12 @@ def setup_platform(hass, config, add_devices, discovery_info=None):

devs = []

for parameter in config[CONF_MONITORED_CONDITIONS]:
if CONF_MONITORED_CONDITIONS in config:
parameters = config[CONF_MONITORED_CONDITIONS]
else:
parameters = SENSOR_TYPES.keys()

for parameter in parameters:
name = SENSOR_TYPES[parameter][0]
unit = SENSOR_TYPES[parameter][1]

Expand Down