Make miflora monitored_conditions parameter optional#7598
Merged
Conversation
|
@frog32, thanks for your PR! By analyzing the history of the files in this pull request, we identified @open-homeautomation, @fabaff and @Danielhiversen to be potential reviewers. |
|
👍 |
balloob
requested changes
May 15, 2017
| PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ | ||
| vol.Required(CONF_MAC): cv.string, | ||
| vol.Required(CONF_MONITORED_CONDITIONS): | ||
| vol.Optional(CONF_MONITORED_CONDITIONS): |
Member
There was a problem hiding this comment.
Can you use the default keyword for vol.Optional instead
pvizeli
previously requested changes
May 15, 2017
| PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({ | ||
| vol.Required(CONF_MAC): cv.string, | ||
| vol.Required(CONF_MONITORED_CONDITIONS): | ||
| vol.Optional(CONF_MONITORED_CONDITIONS, default=SENSOR_TYPES.keys()): |
balloob
approved these changes
May 16, 2017
Member
|
Managed to simplify it even more, no need for list either as default iterable of a dictionary is the keys 👍 |
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
If miflora monitored_conditions is not set default to monitoring all miflora sensors.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2636
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass