Skip to content

Use device_tracker SourceType enum [h-m]#75964

Merged
epenet merged 1 commit intohome-assistant:devfrom
cdce8p:device-tracker_enum-2
Jul 31, 2022
Merged

Use device_tracker SourceType enum [h-m]#75964
epenet merged 1 commit intohome-assistant:devfrom
cdce8p:device-tracker_enum-2

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Jul 30, 2022

Proposed change

Update integrations to use new SourceType enum.
Ref: #75892

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Contributor

@pnbruckner pnbruckner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdce8p cdce8p added the smash Indicator this PR is close to finish for merging or closing label Jul 31, 2022
@epenet epenet merged commit f068fc8 into home-assistant:dev Jul 31, 2022
@cdce8p cdce8p deleted the device-tracker_enum-2 branch July 31, 2022 15:08
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants