Skip to content

Add StrEnum for device_tracker SourceType#75892

Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom
cdce8p:enum-device_trackers
Jul 29, 2022
Merged

Add StrEnum for device_tracker SourceType#75892
MartinHjelmare merged 1 commit intohome-assistant:devfrom
cdce8p:enum-device_trackers

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Jul 28, 2022

Deprecation

Custom integrations only: Deprecate device_tracker SOURCE_TYPE_* constants. Use the SourceType enum instead.

Proposed change

Add new StrEnum for device_tracker SOURCE_TYPE_* constants. This PR only updates the device_tracker integration itself and the device_tracker platform for mobile_app as example. The remaining integration platforms will be updated in follow up PRs if this one is accepted.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner July 28, 2022 20:53
@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (mobile_app) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (device_tracker) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@cdce8p cdce8p force-pushed the enum-device_trackers branch from 79dcde6 to 14845a0 Compare July 28, 2022 22:34
@epenet
Copy link
Copy Markdown
Contributor

epenet commented Jul 29, 2022

Should this have a corresponding dev blog entry?
eg. home-assistant/developers.home-assistant#1295

@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented Jul 29, 2022

Should this have a corresponding dev blog entry?
eg. home-assistant/developers.home-assistant#1295

Opened home-assistant/developers.home-assistant#1414
As draft until the PR is accepted.

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 2b1e136 into home-assistant:dev Jul 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2022
@cdce8p cdce8p deleted the enum-device_trackers branch July 30, 2022 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants