Skip to content

Fix plant MIN_TEMPERATURE, MAX_TEMPERATURE validation #7476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvizeli merged 2 commits into from
May 7, 2017
Merged

Fix plant MIN_TEMPERATURE, MAX_TEMPERATURE validation #7476

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ba3f8d
Fix plant MIN_TEMPERATURE, MAX_TEMPERATURE validation
frog32 May 7, 2017
4db456c
Do not use vol.All for a single validation
frog32 May 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions homeassistant/components/plant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@
PLANT_SCHEMA = vol.Schema({
vol.Required(CONF_SENSORS): vol.Schema(SCHEMA_SENSORS),
vol.Optional(CONF_MIN_BATTERY_LEVEL): cv.positive_int,
vol.Optional(CONF_MIN_TEMPERATURE): cv.small_float,
vol.Optional(CONF_MAX_TEMPERATURE): cv.small_float,
vol.Optional(CONF_MIN_TEMPERATURE): vol.All(vol.Coerce(float)),
vol.Optional(CONF_MAX_TEMPERATURE): vol.All(vol.Coerce(float)),

@MartinHjelmare MartinHjelmare May 7, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need vol.All since there's only one validator.

vol.Optional(CONF_MIN_MOISTURE): cv.positive_int,
vol.Optional(CONF_MAX_MOISTURE): cv.positive_int,
vol.Optional(CONF_MIN_CONDUCTIVITY): cv.positive_int,
Expand Down