Fix plant MIN_TEMPERATURE, MAX_TEMPERATURE validation#7476
Merged
Conversation
small_float only allows values from 0 to 1 so we should use float instead
|
@frog32, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristianKuehnel and @fabaff to be potential reviewers. |
Contributor
MartinHjelmare
requested changes
May 7, 2017
| vol.Optional(CONF_MIN_TEMPERATURE): cv.small_float, | ||
| vol.Optional(CONF_MAX_TEMPERATURE): cv.small_float, | ||
| vol.Optional(CONF_MIN_TEMPERATURE): vol.All(vol.Coerce(float)), | ||
| vol.Optional(CONF_MAX_TEMPERATURE): vol.All(vol.Coerce(float)), |
Member
There was a problem hiding this comment.
You don't need vol.All since there's only one validator.
MartinHjelmare
approved these changes
May 7, 2017
pvizeli
approved these changes
May 7, 2017
Member
|
Cherry-picked for 0.44.1 |
balloob
pushed a commit
that referenced
this pull request
May 7, 2017
* Fix plant MIN_TEMPERATURE, MAX_TEMPERATURE validation small_float only allows values from 0 to 1 so we should use float instead * Do not use vol.All for a single validation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
small_float only allows values from 0 to 1 so we should use float instead
Description:
the plant component uses small_float validation for temperature. Small float only covers floats from 0 to 1.
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass