Skip to content

Move remaining metadata to pyproject#72469

Merged
cdce8p merged 5 commits intohome-assistant:devfrom
cdce8p:metadata-version
May 26, 2022
Merged

Move remaining metadata to pyproject#72469
cdce8p merged 5 commits intohome-assistant:devfrom
cdce8p:metadata-version

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented May 25, 2022

Proposed change

Followup to #72465
Depends on home-assistant/actions#71 -> Merged ✅

Move the remaining metadata keys mentioned in #72465 to pyproject.toml. Mainly version, python_requires, and install_requires. To do so, I updated various scripts and added tomli as test dependency for Python < (3, 11).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner May 25, 2022 02:26
@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label May 25, 2022
@cdce8p cdce8p force-pushed the metadata-version branch from 7adc103 to d1eb317 Compare May 25, 2022 09:12
@cdce8p cdce8p force-pushed the metadata-version branch from d1eb317 to f4c0687 Compare May 25, 2022 09:15
@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented May 26, 2022

Test failure unrelated to changes.

@cdce8p cdce8p merged commit 1ac7145 into home-assistant:dev May 26, 2022
@cdce8p cdce8p deleted the metadata-version branch May 26, 2022 00:54
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants