Update version helpers to handle pyproject.toml#71
Merged
ludeeus merged 6 commits intohome-assistant:masterfrom May 25, 2022
cdce8p:version-parsing
Merged
Update version helpers to handle pyproject.toml#71ludeeus merged 6 commits intohome-assistant:masterfrom cdce8p:version-parsing
ludeeus merged 6 commits intohome-assistant:masterfrom
cdce8p:version-parsing
Conversation
This was referenced May 25, 2022
ludeeus
reviewed
May 25, 2022
ludeeus
reviewed
May 25, 2022
Co-authored-by: Joakim Sørensen <ludeeus@ludeeus.dev>
ludeeus
approved these changes
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to home-assistant/core#72422 To eventually be able to move the version key from
setup.cfgtopyproject.toml, the version helper actions need to be updated.Unfortunately,
tomllibwill only be added in Python 3.11 so we can't rely on it and have to usetomliin the meantime.Instead of installing it every time, I chose to include the contents of the wheel directly. WithPYTHONPATH, it's possible to import it just like as it would be if it is installed.For vendoring, I went with a basic structure structure that's also used by eg. setuptools.