Skip to content

Fix other enums in helpers#71505

Merged
balloob merged 1 commit intodevfrom
fix-other-enums-selectors
May 8, 2022
Merged

Fix other enums in helpers#71505
balloob merged 1 commit intodevfrom
fix-other-enums-selectors

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 7, 2022

Breaking change

Proposed change

I had added a fix + test so selectors wouldn't be able to store enums in validated config anymore in #71441. I incorrectly assumed that all enum config options had tests which was not the case.

This fixes the last 2.

Fixes #71396

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@balloob balloob added this to the 2022.5.3 milestone May 7, 2022
@balloob balloob requested a review from a team as a code owner May 7, 2022 21:26
@probot-home-assistant probot-home-assistant bot added bugfix core small-pr PRs with less than 30 lines. labels May 7, 2022
@balloob balloob merged commit e35a5a1 into dev May 8, 2022
@balloob balloob deleted the fix-other-enums-selectors branch May 8, 2022 03:57
balloob added a commit that referenced this pull request May 8, 2022
@balloob balloob mentioned this pull request May 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to Import Blueprints

3 participants