Skip to content

Stringify enums in selectors#71441

Merged
balloob merged 2 commits intodevfrom
selectors-stringify-enums
May 6, 2022
Merged

Stringify enums in selectors#71441
balloob merged 2 commits intodevfrom
selectors-stringify-enums

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 6, 2022

Breaking change

Proposed change

Blueprint importing validates a blueprint config before importing. The problem was that selector validation would convert certain strings to enums, causing the YAML dump to fail.

This PR makes sure that selectors stringify the enums and added a test to ensure that all future enums are stringified too.

Fixes #71396

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (blueprint) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@balloob balloob added this to the 2022.5.2 milestone May 6, 2022
@balloob
Copy link
Copy Markdown
Member Author

balloob commented May 6, 2022

Verified tests locally.

@balloob balloob merged commit b1a0430 into dev May 6, 2022
@balloob balloob deleted the selectors-stringify-enums branch May 6, 2022 18:25
balloob added a commit that referenced this pull request May 6, 2022
@balloob balloob mentioned this pull request May 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to Import Blueprints

3 participants