Migrate sabnzbd sensors unique ids#71455
Merged
MartinHjelmare merged 9 commits intohome-assistant:devfrom May 9, 2022
Merged
Conversation
probot-home-assistant
bot
added
has-tests
integration: sabnzbd
new-feature
by-code-owner
labels
Contributor
|
Hi @GitHub-Action, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
shaiu
force-pushed
the
sabnzbd_migrate_unique_id
branch
from
c0fc0f1 to
95c28ca
Compare
Contributor
|
Hi @GitHub-Action, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
shaiu
force-pushed
the
sabnzbd_migrate_unique_id
branch
from
95c28ca to
b05231c
Compare
1. migrate sensors to have unique id constructed also from entry_id 2. add migration flow in init 3. bump config flow to version 2 4. add tests for migration
shaiu
force-pushed
the
sabnzbd_migrate_unique_id
branch
from
b05231c to
faa57c9
Compare
Contributor
Author
|
@gjohansson-ST moved it to setup_entry. |
MartinHjelmare
requested changes
May 7, 2022
2. Set up the config entry and not use integration directly 3. remove patch for entity registry
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
MartinHjelmare
changed the title
MartinHjelmare
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Checklist
black --fast homeassistant tests)To help with the load of incoming pull requests: