Merged
Conversation
2. add a service info
probot-home-assistant
bot
added
bugfix
integration: sabnzbd
small-pr
0bmay
reviewed
May 5, 2022
Contributor
0bmay
left a comment
0bmay
left a comment
There was a problem hiding this comment.
code changes do what was explained in the code commits.
balloob
approved these changes
May 5, 2022
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please address the comments in a new PR. Thanks!
| self, sabnzbd_api_data, client_name, description: SabnzbdSensorEntityDescription | ||
| ): | ||
| """Initialize the sensor.""" | ||
| unique_id = description.key |
Member
There was a problem hiding this comment.
Only the key is not unique enough if more than one config entry is setup. We could prefix with the config entry entry_id if there's no better unique_id.
https://developers.home-assistant.io/docs/entity_registry_index#unique-id-requirements
Member
|
We should probably not have included this in a patch release. It's a new feature and now we'll need a migration when fixing the incorrect unique_id. |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Added unique ids to sensors so the integration will show the entities.
Also added a service info section
Type of change
Additional information
Checklist
black --fast homeassistant tests)The integration reached or maintains the following [Integration Quality Scale][quality-scale]:
To help with the load of incoming pull requests: