Skip to content

Fix #7026 adding a new wol parameter#7144

Merged
balloob merged 1 commit into
home-assistant:devfrom
titilambert:wol
Apr 18, 2017
Merged

Fix #7026 adding a new wol parameter#7144
balloob merged 1 commit into
home-assistant:devfrom
titilambert:wol

Conversation

@titilambert
Copy link
Copy Markdown
Contributor

@titilambert titilambert commented Apr 17, 2017

Description:

#6810 introduced a bug on WOL component.
This patch fixes this issue by adding a new parameter to specify the broadcast address where the magic packet should be sent. See the example below.
@goto100 could you confirm that this patch work fine for you ? (be careful, you have to change your configuration)

Related issue (if applicable): fixes #7026

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2445

Example entry for configuration.yaml (if applicable):

switch:
  - platform: wake_on_lan
    mac_address: "00-01-02-03-04-05"
    name: myhost
    host: 192.168.2.13
    broadcast_address: 255.255.255.255

Checklist:

  • Documentation added/updated in home-assistant.github.io
  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@mention-bot
Copy link
Copy Markdown

@titilambert, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @Chris-V and @iamtpage to be potential reviewers.

@mikenolet
Copy link
Copy Markdown

This corrected the issue for me.

@balloob balloob merged commit de71fee into home-assistant:dev Apr 18, 2017
@mikenolet
Copy link
Copy Markdown

I tried it again today under 42.4 and it does not appear to work.

@goto100 goto100 mentioned this pull request Apr 19, 2017
@balloob balloob mentioned this pull request Apr 21, 2017
@titilambert
Copy link
Copy Markdown
Contributor Author

@mikenolet it seems merge in 0.43

@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WOL switch not working in 42.2

5 participants