fix WOL in docker/jail#6810
Merged
Merged
Conversation
add ip_address parameter to send_magic_packet if host specific. in docker/jail, WOL doesn't works due to subnet broadcast issues.
Contributor
balloobbot
added
platform
via-github
and removed
cla-needed
platform: switch.wake_on_lan
labels
houndci-bot
reviewed
Mar 27, 2017
| """Turn the device on.""" | ||
| self._wol.send_magic_packet(self._mac_address) | ||
| if self._host: | ||
| self._wol.send_magic_packet(self._mac_address, ip_address=self._host) |
There was a problem hiding this comment.
line too long (81 > 79 characters)
Contributor
Author
Merged
Contributor
|
This commit seems to have contributed to #7026 |
This was referenced Apr 15, 2017
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
in docker/jail, WOL doesn't works due to subnet multicast issues.
add ip_address parameter to send_magic_packet if host specific.