Remove logbook split_entity_id caching

[bdraco]

Proposed change

Remove logbook split_entity_id caching

This is no longer needed since split_entity_id is already cached.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (logbook) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[balloob]

Nice!

I think that we have a similar approach on state objects too in core.py btw.

[bdraco]

Nice!

I think that we have a similar approach on state objects too in core.py btw.

Looks like we get self.domain, self.object_id = split_entity_id(self.entity_id) for free already in State __init__ from the last change

[balloob]

Right, I guess I was just thinking that we could even remove it and let it compute it on the fly so we don't compute it without needing it.

[bdraco]

Right, I guess I was just thinking that we could even remove it and let it compute it on the fly so we don't compute it without needing it.

Ahh.. Yeah that makes sense. We used to always access it because we recorded the domain in the db, but I think it makes sense to make it lazy now

[bdraco]

The problem is we call async_all(DOMAIN) frequently which accesses the domain for every state in the state machine so we end up creating it anyways. It also probably doesn't matter too much in this case as its not like logbook where we see the same entity_id 10000s of times in a call