Add cache to split_entity_id#71345
Merged
balloob merged 1 commit intohome-assistant:devfrom May 5, 2022
Merged
Conversation
emontnemery
approved these changes
May 5, 2022
| # How long to wait until things that run on startup have to finish. | ||
| TIMEOUT_EVENT_START = 15 | ||
|
|
||
| MAX_EXPECTED_ENTITY_IDS = 16384 |
Contributor
There was a problem hiding this comment.
Powers of two are best number 😄
balloob
approved these changes
May 5, 2022
Member
|
Did we time this if this is faster? Splitting a string isn't that expensive? |
Member
Author
|
Yes, its about 30% faster on average even with the lru overhead. The only time its slower is when we evict from the lru cache which will likely never happen with the size of the cache. We can also dump the caching in logbook as well in #71359 |
Member
|
That's pretty wild, it's such a small function. |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add cache to split_entity_id
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: