Use ColorMode enum in yeelight#70560
Merged
bdraco merged 2 commits intohome-assistant:devfrom Apr 23, 2022
Merged
Conversation
probot-home-assistant
bot
added
code-quality
integration: yeelight
small-pr
|
Hey there @zewelor, @shenxn, @starkillerOG, @alexyao2015, mind taking a look at this pull request as it has been labeled with an integration ( |
bdraco
reviewed
Apr 23, 2022
|
|
||
| _attr_color_mode: str | None = COLOR_MODE_BRIGHTNESS | ||
| _attr_supported_color_modes: set[str] | None = {COLOR_MODE_BRIGHTNESS} | ||
| _attr_color_mode: ColorMode | str | None = ColorMode.BRIGHTNESS |
Member
There was a problem hiding this comment.
Can we drop the None typing here and the next line?
Contributor
Author
There was a problem hiding this comment.
Should be solved with new inheritance.
bdraco
reviewed
Apr 23, 2022
|
|
||
| _attr_color_mode: str | None = COLOR_MODE_COLOR_TEMP | ||
| _attr_supported_color_modes: set[str] | None = {COLOR_MODE_COLOR_TEMP} | ||
| _attr_color_mode: ColorMode | str | None = ColorMode.COLOR_TEMP |
epenet
commented
Apr 23, 2022
|
|
||
|
|
||
| class YeelightWhiteTempLightSupport: | ||
| class YeelightWhiteTempLightSupport(YeelightGenericLight): |
Contributor
Author
There was a problem hiding this comment.
This inheritance was added to solve mypy issues.
bdraco
approved these changes
Apr 23, 2022
bdraco
approved these changes
Apr 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Use ColorMode enum, as follow-up to #69223, and required for #69302
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: