Skip to content

Add ColorMode enum to light platform#69223

Merged
frenck merged 2 commits intodevfrom
frenck-2022-0839
Apr 11, 2022
Merged

Add ColorMode enum to light platform#69223
frenck merged 2 commits intodevfrom
frenck-2022-0839

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Apr 3, 2022

Breaking change

Developers only: All COLOR_MODE_* constants have been deprecated and replaced by a ColorMode enum.

Proposed change

See above.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (light) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (demo) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck force-pushed the frenck-2022-0839 branch from 197c403 to 6f0b6d6 Compare April 10, 2022 18:24
COLOR_MODE_WHITE = "white" # Must *NOT* be the only supported mode
COLOR_MODE_WHITE = "white"

VALID_COLOR_MODES = {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a follow-up PR we might be able to get rid of this constant because whatever uses this constant should check if the enum has this value.

@frenck frenck marked this pull request as ready for review April 11, 2022 11:27
@frenck frenck requested a review from a team as a code owner April 11, 2022 11:27
@frenck frenck merged commit 27bc5e1 into dev Apr 11, 2022
@frenck frenck deleted the frenck-2022-0839 branch April 11, 2022 16:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants