More sensors for SMS integration#70486
Conversation
|
Hey there @ocalvo, mind taking a look at this pull request as it has been labeled with an integration ( |
jorhett
left a comment
jorhett
left a comment
There was a problem hiding this comment.
Best written PR description I've seen today.
I have no means to test/evaluate the code in question, but it is more readable than the code it replaces which is always a plus.
ocalvo
left a comment
ocalvo
left a comment
There was a problem hiding this comment.
Thank you for doing this.
This may have a merge conflict with #68320 |
|
@ocalvo looks not difficult to merge. Let's see which PR will be merged into |
|
Keep alive |
|
@PaulAnnekov can you fix the merge conflicts? |
|
@ocalvo will do |
|
@ocalvo merged |
frenck
added
the
smash
| ] | ||
|
|
||
| SIGNAL_SENSORS: Final[dict[str, SensorEntityDescription]] = { | ||
| "SignalStrength": SensorEntityDescription( |
There was a problem hiding this comment.
For a future PR, you can add state_class=MEASUREMENT for this and others so stats are being generated
| ), | ||
| } | ||
|
|
||
| NETWORK_SENSORS: Final[dict[str, SensorEntityDescription]] = { |
There was a problem hiding this comment.
If the dict keys are not used, why are these dicts and not tuples?
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please address the comment in a new PR. Thanks!
| {"value": "115200", "label": "115200"}, | ||
| ] | ||
|
|
||
| SIGNAL_SENSORS: Final[dict[str, SensorEntityDescription]] = { |
There was a problem hiding this comment.
Please move the sensor entity descriptions to the sensor platform. These are platform details.
7 participants
Breaking change
GSM signal sensor entity was replaced with a set of more granular ones. It will become unavailable after update.
Proposed change
Currently SMS integration exposes only a single entity with 3 attributes. It shows signal strength. As it's not enough to understand what happens with mobile modem, I've added more entities that report: network name, cell id, network code, etc. Also, moved attributes of signal entity to separate entities as it makes UX better.
New entities:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: