Support custom baud speed#68320
Conversation
frenck
added
the
smash
frenck
removed
the
smash
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
|
keep alive |
1 similar comment
|
keep alive |
|
Keep alive |
|
@frenck Can you merge this? |
| import voluptuous as vol | ||
| import logging | ||
|
|
||
| import voluptuous as vol # pylint: disable=import-error |
There was a problem hiding this comment.
Why is this causing an import error that needs to be disabled?
There was a problem hiding this comment.
It seems pylint does not know about the gammu lib for some reason.
There was a problem hiding this comment.
This comment is made on de Voluptuous import, not the gammu library
There was a problem hiding this comment.
Ahh I remember now. Pylint entered an infinite loop complaining about wrong import order. X before Y.
When trying to fix it then it complain than Y before X as so on.
The only way I was able to fix it was to ignore the import.
I should have added a comment.
There was a problem hiding this comment.
That sounds incorrect or maybe an issue in your environment. We don't use pylint for import ordering, as a matter of fact, the order is disabled:
The error you are disabling in the comment is an import-error, which should not occur for voluptuous
There was a problem hiding this comment.
Perhaps you are correct.
My dev environment is based on WSL and by following the handbook I see a failure in scripts/setup complaining about a bad parameter for pip. I ask in the dev community channel but got no solutions.
I workaround this by removing the parameter which then problaby corrupted my pylint.
I will remove all of these in my real Ubuntu dev box and see if I get better results.
There was a problem hiding this comment.
Perhaps you are correct. My dev environment is based on WSL and by following the handbook I see a failure in scripts/setup complaining about a bad parameter for pip. I ask in the dev community channel but got no solutions.
I workaround this by removing the parameter which then problaby corrupted my pylint.
I will remove all of these in my real Ubuntu dev box and see if I get better results.
Resolved by using docker container.
|
|
||
| import gammu # pylint: disable=import-error | ||
| import voluptuous as vol | ||
| import voluptuous as vol # pylint: disable=wrong-import-order, import-error |
There was a problem hiding this comment.
Why are these disabled?
Resolved
| from .const import DOMAIN | ||
| from homeassistant.helpers import selector | ||
|
|
||
| from .const import ( # pylint: disable=unused-import |
There was a problem hiding this comment.
All of them are used? Why is this pylint check disabled?
There was a problem hiding this comment.
All of them are used? Why is this pylint check disabled?
Resolved
|
After This is most likely not related to this change. |
|
Keep alive |
3 participants
Breaking change: no
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: