Lutron. Bugfix callback registration.#7042
Merged
Merged
Conversation
balloob
reviewed
Apr 11, 2017
Member
Author
There was a problem hiding this comment.
Yes it add only a callback into dict
Member
Author
There was a problem hiding this comment.
Like the other lutron component.
Contributor
|
Sorry for the lack of updates folks. Been busy at work and now on vacation.
I'll try to get back to this when I'm back if you don't take care of it
beforehand. The pylutron library itself is not guaranteed to be async safe.
…On Apr 11, 2017 11:57 AM, "Paulus Schoutsen" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In homeassistant/components/lutron.py
<#7042 (comment)>
:
> """Initialize the device."""
self._lutron_device = lutron_device
self._controller = controller
self._area_name = area_name
- self.hass = hass
- self.object_id = '{} {}'.format(area_name, lutron_device.name)
-
+ @asyncio.coroutine
+ def async_add_to_hass(self):
+ """Register callbacks."""
self._controller.subscribe(self._lutron_device, self._update_callback)
Is this async friendly?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7042 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABcEMVV4OwJYC0Sp992hIsM__nKWelDaks5ru6MBgaJpZM4M53FJ>
.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #6739
CC #7019