Fix Lutron component broken by #6580#6739
Closed
thecynic wants to merge 1 commit into
Closed
Conversation
Contributor
houndci-bot
reviewed
Mar 22, 2017
There was a problem hiding this comment.
line too long (87 > 79 characters)
0463c44 to
11faee5
Compare
Member
|
I think the right approach is to move the callback registration into |
Member
|
Look to other lutron component to see what I mean. |
Member
|
@thecynic what you want to do? |
Contributor
Author
|
Sorry, been busy with work stuff. I'll upload a new change in the next few
days.
…On Mar 29, 2017 12:52 PM, "Pascal Vizeli" ***@***.***> wrote:
@thecynic <https://github.com/thecynic> what you want to do?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6739 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABcEMS7yYkzjGwjB6WI6AKhGR5f2pq5wks5rqrZ2gaJpZM4MkzaY>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This fixes the Lutron component that got broken by #6580.
If we don't set the entity_id at initiliazatioon on the Entity, things freak out when we schedule ha state update.