Skip to content

Fix Lutron component broken by #6580#6739

Closed
thecynic wants to merge 1 commit into
home-assistant:devfrom
thecynic:dev-fix-lutron
Closed

Fix Lutron component broken by #6580#6739
thecynic wants to merge 1 commit into
home-assistant:devfrom
thecynic:dev-fix-lutron

Conversation

@thecynic
Copy link
Copy Markdown
Contributor

Description:

This fixes the Lutron component that got broken by #6580.

If we don't set the entity_id at initiliazatioon on the Entity, things freak out when we schedule ha state update.

@mention-bot
Copy link
Copy Markdown

@thecynic, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pvizeli and @fabaff to be potential reviewers.

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @thecynic,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (87 > 79 characters)

@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Mar 22, 2017

I think the right approach is to move the callback registration into async_added_to_hass or at EVENT_HOMEASSISTANT_START event listener.

@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Mar 25, 2017

Look to other lutron component to see what I mean.

@pvizeli
Copy link
Copy Markdown
Member

pvizeli commented Mar 29, 2017

@thecynic what you want to do?

@thecynic
Copy link
Copy Markdown
Contributor Author

thecynic commented Mar 30, 2017 via email

@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
@ghost ghost removed the platform: light.lutron label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants