Skip to content

Cache newly written state attribute ids #68355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdraco merged 4 commits into from
Mar 23, 2022
Merged

Cache newly written state attribute ids #68355

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59e9050
Cache newly written state attribute ids
bdraco Mar 19, 2022
73b9a54
Merge branch 'dev' into cache_newly_written_ids
bdraco Mar 20, 2022
45e1a89
Merge branch 'dev' into cache_newly_written_ids
bdraco Mar 20, 2022
b147c69
Merge branch 'dev' into cache_newly_written_ids
bdraco Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion homeassistant/components/recorder/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,9 +1116,18 @@ def _commit_event_session(self):
if dbstate in self.event_session:
self.event_session.expunge(dbstate)
self._pending_expunge = []
self._pending_state_attributes = {}
self.event_session.commit()

# We just committed the state attributes to the database
# and we now know the attributes_ids. We can save
# a many selects for matching attributes by loading them
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can save many selects

Copy link
Copy Markdown
Member Author

@bdraco bdraco Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it in my typing cleanup branch. I pulled out just the __init__.py file into a smaller PR: #68551

# into the LRU cache now.
for state_attr in self._pending_state_attributes.values():
self._state_attributes_ids[
state_attr.shared_attrs
] = state_attr.attributes_id
self._pending_state_attributes = {}

# Expire is an expensive operation (frequently more expensive
# than the flush and commit itself) so we only
# do it after EXPIRE_AFTER_COMMITS commits
Expand Down