Cache newly written state attribute ids#68355
Merged
bdraco merged 4 commits intohome-assistant:devfrom Mar 23, 2022
Merged
Conversation
- Once commit the new state attributes to the database the attributes_id field will be filled out. Since we have them we can add them to the cache before we clear the pending state attributes to avoid selecting them the next time we have a matching attribute set
probot-home-assistant
bot
added
code-quality
core
integration: recorder
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
bdraco
added
the
smash
balloob
approved these changes
Mar 23, 2022
Member
Author
|
Thanks. I think that's the last of recorder optimizations for a bit. Although I'm afraid to say that as I usually find something right after I do 🙈 |
|
|
||
| # We just committed the state attributes to the database | ||
| # and we now know the attributes_ids. We can save | ||
| # a many selects for matching attributes by loading them |
Member
There was a problem hiding this comment.
We can save many selects
Member
Author
There was a problem hiding this comment.
I fixed it in my typing cleanup branch. I pulled out just the __init__.py file into a smaller PR: #68551
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
The comment in #68224 (comment) got me thinking about ways to reduce the number of selects. Thanks @emontnemery for getting me thinking down that path.
attributes_idfield will be filled out. Since we havethem we can add them to the cache before we clear
the pending state attributes to avoid selecting them
the next time we have a matching attribute set
The existing tests cover this optimization
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: