lights/hue: use device class for on/off devices like the osram lightify plug#6817
Merged
Conversation
Contributor
emlove
reviewed
Mar 27, 2017
| PHUE_CONFIG_FILE = 'phue.conf' | ||
|
|
||
| SUPPORT_HUE_ON_OFF = (SUPPORT_FLASH | SUPPORT_TRANSITION | SUPPORT_FLASH) | ||
| SUPPORT_HUE_ON_OFF = (SUPPORT_FLASH | SUPPORT_TRANSITION) |
Contributor
There was a problem hiding this comment.
SUPPORT_FLASH needs to be reintroduced somewhere in the chain here. Presumably at SUPPORT_HUE_DIMMABLE, but I'm not sure.
Contributor
Author
There was a problem hiding this comment.
I'm fixing only the nonsensical "SUPPORT_FLASH | SUPPORT_FLASH" for SUPPORT_HUE_ON_OFF
Contributor
There was a problem hiding this comment.
Oh wow, I missed that. Nevermind. :)
Contributor
Author
There was a problem hiding this comment.
Although for the lightify plug it could make sense to remove the SUPPORT_FLASH altogether. It uses a relais and is rather slow. I'm not sure for how many switch operations the relais is specified.
After looking at it now, I'm not sure if the SUPPORT_TRANSITION makes sense.
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a typo in the SUPPORT_HUE_ON_OFF definition and adds support for the device class as reported for the Osram Lightify Plug