Skip to content

lights/hue: use device class for on/off devices like the osram lightify plug #6817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvizeli merged 2 commits into from
Mar 27, 2017
Merged

lights/hue: use device class for on/off devices like the osram lightify plug #6817

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8375a1
hue: remove duplicate SUPPORT_FLASH flag
jannau Mar 13, 2017
2ea9a1e
hue: use correct device class for the Osram Lightify Plug
jannau Mar 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion homeassistant/components/light/hue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@

PHUE_CONFIG_FILE = 'phue.conf'

SUPPORT_HUE_ON_OFF = (SUPPORT_FLASH | SUPPORT_TRANSITION | SUPPORT_FLASH)
SUPPORT_HUE_ON_OFF = (SUPPORT_FLASH | SUPPORT_TRANSITION)
Copy link
Copy Markdown
Contributor

@emlove emlove Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUPPORT_FLASH needs to be reintroduced somewhere in the chain here. Presumably at SUPPORT_HUE_DIMMABLE, but I'm not sure.

Copy link
Copy Markdown
Contributor Author

@jannau jannau Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fixing only the nonsensical "SUPPORT_FLASH | SUPPORT_FLASH" for SUPPORT_HUE_ON_OFF

Copy link
Copy Markdown
Contributor

@emlove emlove Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, I missed that. Nevermind. :)

Copy link
Copy Markdown
Contributor Author

@jannau jannau Mar 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although for the lightify plug it could make sense to remove the SUPPORT_FLASH altogether. It uses a relais and is rather slow. I'm not sure for how many switch operations the relais is specified.
After looking at it now, I'm not sure if the SUPPORT_TRANSITION makes sense.

SUPPORT_HUE_DIMMABLE = (SUPPORT_HUE_ON_OFF | SUPPORT_BRIGHTNESS)
SUPPORT_HUE_COLOR_TEMP = (SUPPORT_HUE_DIMMABLE | SUPPORT_COLOR_TEMP)
SUPPORT_HUE_COLOR = (SUPPORT_HUE_DIMMABLE | SUPPORT_EFFECT |
Expand All @@ -58,6 +58,7 @@
'Extended color light': SUPPORT_HUE_EXTENDED,
'Color light': SUPPORT_HUE_COLOR,
'Dimmable light': SUPPORT_HUE_DIMMABLE,
'On/Off plug-in unit': SUPPORT_HUE_ON_OFF,
'Color temperature light': SUPPORT_HUE_COLOR_TEMP
}

Expand Down