Skip to content

bugfix [Zwave lock] Typo error and update test#6757

Merged
balloob merged 1 commit into
home-assistant:devfrom
turbokongen:zwave-lock
Mar 24, 2017
Merged

bugfix [Zwave lock] Typo error and update test#6757
balloob merged 1 commit into
home-assistant:devfrom
turbokongen:zwave-lock

Conversation

@turbokongen
Copy link
Copy Markdown
Contributor

Description:

Update for a minor type noticed by @swbradshaw

@mention-bot
Copy link
Copy Markdown

@turbokongen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @devdelay, @balloob and @armills to be potential reviewers.

@emlove
Copy link
Copy Markdown
Contributor

emlove commented Mar 23, 2017

Good catch.

Should we leave the 'by' in LOCK_ALARM_TYPE, though? At this point it'll be in here twice either way, but MANUAL_LOCK_ALARM_LEVEL seems more likely to expand later.

@turbokongen
Copy link
Copy Markdown
Contributor Author

My intention is that if you manually unlock/lock and the lock does not report a MANUAL_LOCK_ALARM_TYPE,, the the message does not contain a 'by', but if it does, it fills with the completed content in MANUAL_LOCK_ALARM_TYPE ?

@emlove
Copy link
Copy Markdown
Contributor

emlove commented Mar 23, 2017

That makes sense. Works for me.

turbokongen referenced this pull request Mar 23, 2017
* ZWave Lock Tests

* Linting fixes

* Missed coveragerc
@balloob balloob added this to the 0.41 milestone Mar 24, 2017
@balloob balloob merged commit ee6c9ab into home-assistant:dev Mar 24, 2017
@fabaff fabaff mentioned this pull request Apr 6, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Jun 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants