Skip to content

ZWave Lock Tests#6730

Merged
balloob merged 3 commits into
home-assistant:devfrom
emlove:zwave-lock-tests
Mar 21, 2017
Merged

ZWave Lock Tests#6730
balloob merged 3 commits into
home-assistant:devfrom
emlove:zwave-lock-tests

Conversation

@emlove
Copy link
Copy Markdown
Contributor

@emlove emlove commented Mar 21, 2017

Description:

This PR also includes some small fixes I found during testing. This should be the last of the individual ZWave platforms.

#6437

@mention-bot
Copy link
Copy Markdown

@armills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @turbokongen, @balloob and @devdelay to be potential reviewers.

Comment thread tests/components/lock/test_zwave.py Outdated
zwave.DOMAIN, zwave.SERVICE_CLEAR_USERCODE, {
const.ATTR_NODE_ID: node.node_id,
zwave.ATTR_CODE_SLOT: 1,
})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line missing indentation or outdented

Comment thread tests/components/lock/test_zwave.py Outdated
zwave.DOMAIN, zwave.SERVICE_GET_USERCODE, {
const.ATTR_NODE_ID: node.node_id,
zwave.ATTR_CODE_SLOT: 1,
})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line missing indentation or outdented

Comment thread tests/components/lock/test_zwave.py Outdated
const.ATTR_NODE_ID: node.node_id,
zwave.ATTR_USERCODE: '12345',
zwave.ATTR_CODE_SLOT: 1,
})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line missing indentation or outdented

Comment thread tests/components/lock/test_zwave.py Outdated
const.ATTR_NODE_ID: node.node_id,
zwave.ATTR_USERCODE: '1234',
zwave.ATTR_CODE_SLOT: 1,
})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line missing indentation or outdented

Comment thread homeassistant/components/lock/zwave.py Outdated
SERVICE_CLEAR_USERCODE,
clear_usercode,
descriptions.get(SERVICE_CLEAR_USERCODE),
schema=CLEAR_USERCODE_SCHEMA)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line under-indented for visual indent

Comment thread homeassistant/components/lock/zwave.py Outdated
descriptions.get(SERVICE_SET_USERCODE),
schema=SET_USERCODE_SCHEMA)
hass.services.async_register(DOMAIN,
SERVICE_GET_USERCODE,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line under-indented for visual indent

Comment thread homeassistant/components/lock/zwave.py Outdated
SERVICE_SET_USERCODE,
set_usercode,
descriptions.get(SERVICE_SET_USERCODE),
schema=SET_USERCODE_SCHEMA)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line under-indented for visual indent

Comment thread homeassistant/components/lock/zwave.py Outdated
hass.services.async_register(DOMAIN,
SERVICE_SET_USERCODE,
set_usercode,
descriptions.get(SERVICE_SET_USERCODE),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line under-indented for visual indent

Comment thread homeassistant/components/lock/zwave.py Outdated
schema=CLEAR_USERCODE_SCHEMA)
hass.services.async_register(DOMAIN,
SERVICE_SET_USERCODE,
set_usercode,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line under-indented for visual indent

Comment thread homeassistant/components/lock/zwave.py Outdated
descriptions.get(SERVICE_CLEAR_USERCODE),
schema=CLEAR_USERCODE_SCHEMA)
hass.services.async_register(DOMAIN,
SERVICE_SET_USERCODE,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line under-indented for visual indent

@balloob
Copy link
Copy Markdown
Member

balloob commented Mar 21, 2017

Looks good! 🐬

@balloob balloob merged commit e7425e9 into home-assistant:dev Mar 21, 2017
@emlove emlove deleted the zwave-lock-tests branch March 21, 2017 15:56
turbokongen referenced this pull request Mar 23, 2017
* cleanup

* Update __init__.py

* Update __init__.py

* Update __init__.py
@balloob balloob mentioned this pull request Mar 24, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Jun 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants