-
-
Notifications
You must be signed in to change notification settings - Fork 38k
Insteon lib #6505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Insteon lib #6505
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4156b71
use lib with caching to reduce collisions
craigjmidwinter 50a2a98
use 0.43
craigjmidwinter b4a3a33
Merge branch 'dev' of git://github.com/home-assistant/home-assistant …
craigjmidwinter ffa2130
change requirements
craigjmidwinter 7b6b578
update the lib to 0.44
camrun91 f8e268a
update req
camrun91 c04189d
fix typo
camrun91 f5cf898
just keep checking
craigjmidwinter 0f55d41
Merge remote-tracking branch 'origin/insteon-lib' into insteon-lib
craigjmidwinter c9f2fe7
just keep checking - switch
craigjmidwinter 19c52dd
Merge branch 'dev' of git://github.com/home-assistant/home-assistant …
craigjmidwinter 6a6b14e
use 0.45 with file cache
craigjmidwinter 879a229
requirements
craigjmidwinter 7ead7d5
Update requirements_all.txt
camrun91 7a32d92
Update insteon_local.py
camrun91 90e98a6
Update requirements_all.txt
camrun91 7425a27
Update insteon_local.py
camrun91 682ce37
Merge branch 'dev' of git://github.com/home-assistant/home-assistant …
craigjmidwinter 755ad3a
Merge branch 'dev' of git://github.com/home-assistant/home-assistant …
craigjmidwinter d5247e7
update library
craigjmidwinter 659b649
fix lint
craigjmidwinter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,6 +143,10 @@ def unique_id(self): | |
| def update(self): | ||
| """Get the updated status of the switch.""" | ||
| resp = self.node.status(0) | ||
|
|
||
| while 'error' in resp and resp['error'] == True: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. comparison to True should be 'if cond is True:' or 'if cond:' |
||
| resp = self.node.status(0) | ||
|
|
||
| if 'cmd2' in resp: | ||
| self._state = int(resp['cmd2'], 16) > 0 | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comparison to True should be 'if cond is True:' or 'if cond:'