Insteon lib#6505
Merged
Merged
Conversation
Contributor
houndci-bot
reviewed
Mar 9, 2017
| """Get the updated status of the switch.""" | ||
| resp = self.node.status(0) | ||
|
|
||
| while 'error' in resp and resp['error'] == True: |
There was a problem hiding this comment.
comparison to True should be 'if cond is True:' or 'if cond:'
| """Update state of the light.""" | ||
| resp = self.node.status(0) | ||
|
|
||
| while 'error' in resp and resp['error'] == True: |
There was a problem hiding this comment.
comparison to True should be 'if cond is True:' or 'if cond:'
Contributor
pvizeli
approved these changes
Mar 10, 2017
pvizeli
pushed a commit
that referenced
this pull request
Mar 10, 2017
* use lib with caching to reduce collisions * use 0.43 * change requirements * update the lib to 0.44 * update req * fix typo * just keep checking * just keep checking - switch * use 0.45 with file cache * requirements * Update requirements_all.txt * Update insteon_local.py * Update requirements_all.txt * Update insteon_local.py * update library * fix lint
Merged
ghost
removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
updating library version (bugfixes and rate limiting)
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass