Skip to content

Fix UniFi remove client service if time stamps are not integers #63998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kane610 merged 3 commits into from
Jan 13, 2022
Merged

Fix UniFi remove client service if time stamps are not integers #63998

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba5c8d2
Only calculate total time if first and last seen are ints, else remov…
Kane610 Jan 12, 2022
2004e65
Update homeassistant/components/unifi/services.py
Kane610 Jan 13, 2022
5384fb6
Update homeassistant/components/unifi/services.py
Kane610 Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion homeassistant/components/unifi/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ async def async_remove_clients(hass, data) -> None:

for client in controller.api.clients_all.values():

if client.last_seen - client.first_seen > 900:
if (
all({client.last_seen, client.first_seen})
Comment thread
Kane610 marked this conversation as resolved.
Outdated
and client.last_seen - client.first_seen > 900
):
continue

if any({client.fixed_ip, client.hostname, client.name}):
Expand Down
5 changes: 4 additions & 1 deletion tests/components/unifi/test_services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@ async def test_reconnect_wired_client(hass, aioclient_mock):
async def test_remove_clients(hass, aioclient_mock):
"""Verify removing different variations of clients work."""
clients = [
{
"mac": "00:00:00:00:00:00",
},
{
"first_seen": 100,
"last_seen": 500,
Expand Down Expand Up @@ -239,7 +242,7 @@ async def test_remove_clients(hass, aioclient_mock):
await hass.services.async_call(UNIFI_DOMAIN, SERVICE_REMOVE_CLIENTS, blocking=True)
assert aioclient_mock.mock_calls[0][2] == {
"cmd": "forget-sta",
"macs": ["00:00:00:00:00:01"],
"macs": ["00:00:00:00:00:00", "00:00:00:00:00:01"],
}

assert await hass.config_entries.async_unload(config_entry.entry_id)
Expand Down