Skip to content

Fix UniFi remove client service if time stamps are not integers#63998

Merged
Kane610 merged 3 commits intohome-assistant:devfrom
Kane610:unifi-remove_client_service_time_stamps_may_not_be_none
Jan 13, 2022
Merged

Fix UniFi remove client service if time stamps are not integers#63998
Kane610 merged 3 commits intohome-assistant:devfrom
Kane610:unifi-remove_client_service_time_stamps_may_not_be_none

Conversation

@Kane610
Copy link
Copy Markdown
Member

@Kane610 Kane610 commented Jan 12, 2022

Breaking change

Proposed change

Verify that both first and last seen are not None, else client can be removed

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 changed the title Fix UniFi remove client service if time stamps are not ints Fix UniFi remove client service if time stamps are not integers Jan 12, 2022
@Kane610
Copy link
Copy Markdown
Member Author

Kane610 commented Jan 12, 2022

Awesome! Thanks @thecode 🎉

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@Kane610 Kane610 merged commit bc7624b into home-assistant:dev Jan 13, 2022
@Kane610 Kane610 deleted the unifi-remove_client_service_time_stamps_may_not_be_none branch January 13, 2022 07:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure to run unifi.remove_clients service call

4 participants