Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @mletenay, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration ( |
| if DOMAIN not in hass.data: | ||
| hass.data[DOMAIN] = EntityComponent(_LOGGER, DOMAIN, hass) | ||
|
|
||
| component = hass.data[DOMAIN] |
There was a problem hiding this comment.
Was just thinking, this makes it Any, which is suboptimal as well.
This works better:
| component = hass.data[DOMAIN] | |
| component: EntityComponent = hass.data[DOMAIN] |
It does reveal new issues though.
There was a problem hiding this comment.
Three options:
- take it out of [g] and treat it separately
- keep is as Any and consider a follow-up PR
- continue fixing here
I'm inclined to do option 1
There was a problem hiding this comment.
🤷 depends on the changeset.
I'm fine with 1 or 3, 2 is a bit tricky actually as everything seems fine but isn't.
There was a problem hiding this comment.
I have reverted the changes to group.
It looks like it will need quite a bit of work to get working.
There was a problem hiding this comment.
(and as a bonus it should make CI run partial instead of full)
There was a problem hiding this comment.
It does :)
Pretty darn happy with that CI stuff nowadays 👯
Proposed change
As follow-up to #63098, add more setup type hints.
These components needed a few tweaks to pass mypy.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: