Skip to content

Add setup type hints [g]#63432

Merged
frenck merged 7 commits intohome-assistant:devfrom
epenet:mypy-annotations-g
Jan 5, 2022
Merged

Add setup type hints [g]#63432
frenck merged 7 commits intohome-assistant:devfrom
epenet:mypy-annotations-g

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Jan 5, 2022

Proposed change

As follow-up to #63098, add more setup type hints.

These components needed a few tweaks to pass mypy.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (group) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @mletenay, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (goodwe) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jan 5, 2022
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Jan 5, 2022
if DOMAIN not in hass.data:
hass.data[DOMAIN] = EntityComponent(_LOGGER, DOMAIN, hass)

component = hass.data[DOMAIN]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just thinking, this makes it Any, which is suboptimal as well.

This works better:

Suggested change
component = hass.data[DOMAIN]
component: EntityComponent = hass.data[DOMAIN]

It does reveal new issues though.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three options:

  1. take it out of [g] and treat it separately
  2. keep is as Any and consider a follow-up PR
  3. continue fixing here

I'm inclined to do option 1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 depends on the changeset.

I'm fine with 1 or 3, 2 is a bit tricky actually as everything seems fine but isn't.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted the changes to group.
It looks like it will need quite a bit of work to get working.

Copy link
Copy Markdown
Contributor Author

@epenet epenet Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and as a bonus it should make CI run partial instead of full)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does :)
Pretty darn happy with that CI stuff nowadays 👯

@frenck frenck merged commit eed6ca5 into home-assistant:dev Jan 5, 2022
@epenet epenet deleted the mypy-annotations-g branch January 5, 2022 12:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants