Skip to content

Add init type hints [a]#63098

Merged
allenporter merged 1 commit intohome-assistant:devfrom
epenet:init-setup-a
Dec 31, 2021
Merged

Add init type hints [a]#63098
allenporter merged 1 commit intohome-assistant:devfrom
epenet:init-setup-a

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Dec 30, 2021

Proposed change

Add type hint to __init__.py for:

  • setup
  • async_setup
  • async_setup_entry
  • async_remove_entry
  • async_unload_entry
  • async_migrate_entry

This PR is 100% type hint - zero code change. The components with code changes will be treated separately.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Dec 30, 2021

To avoid too big a PR, I will be treating the platforms separately.
If you wish to update the title, please go ahead and I will use the new name for the follow-up PRs.

Copy link
Copy Markdown
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@allenporter allenporter merged commit 545e321 into home-assistant:dev Dec 31, 2021
@epenet epenet deleted the init-setup-a branch December 31, 2021 08:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants