Skip to content

Revert nest reloading due to lock up #63206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 1 commit into from
Jan 2, 2022
Merged

Revert nest reloading due to lock up #63206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions homeassistant/components/nest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,7 @@ def __init__(
async def async_handle_event(self, event_message: EventMessage) -> None:
"""Process an incoming EventMessage."""
if event_message.relation_update:
# A device was added/removed or a home was added/removed. Reload the integration
# in order to detect any changes.
_LOGGER.info("Devices or homes have changed; Reloading")
self._hass.async_create_task(self._config_reload_cb())
_LOGGER.info("Devices or homes have changed; Need reload to take effect")
return
if not event_message.resource_update_name:
return
Expand Down
4 changes: 2 additions & 2 deletions tests/components/nest/test_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,6 @@ async def test_structure_update_event(hass):
# No home assistant events published
assert not events

# Both enties now exist
assert registry.async_get("camera.front")
assert registry.async_get("camera.back")
# Currently need a manual reload to detect the new entity
assert not registry.async_get("camera.back")