Skip to content

Revert nest reloading due to lock up#63206

Merged
frenck merged 1 commit intohome-assistant:devfrom
allenporter:nest-reload
Jan 2, 2022
Merged

Revert nest reloading due to lock up#63206
frenck merged 1 commit intohome-assistant:devfrom
allenporter:nest-reload

Conversation

@allenporter
Copy link
Contributor

@allenporter allenporter commented Jan 2, 2022

Breaking change

Proposed change

Partial revert of PR #62976. Don't reload the integration on pubsub messages since it can lock up Home Assistant.

This seems to have been resolved in March-era google-cloud-pubsub releases, and I was using newer versions initially locally testing this change locally. Noticed on a Supervised version of Hass when testing a dev build.

Home assistant is pinned to an older google-cloud-pubsub versions that are currently pinned to until #56669 is resolved because the home assistant wheel building process breaks GRPC on alpine.

See note in https://googleapis.dev/python/pubsub/latest/subscriber/api/futures.html#google.cloud.pubsub_v1.subscriber.futures.StreamingPullFuture.cancel about cancellation:

Changed in version 2.4.1: The method does not block anymore, it just triggers the shutdown and returns immediately. To block until the background stream is terminated, call result() after cancelling the future

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Revert reloading the integration on pubsub messages since it can lock
up the home assistant worker thread on older google-cloud-pubsub versions
that we're currently pinned to until home-assistant#56669 is resolved
@frenck
Copy link
Member

frenck commented Jan 2, 2022

Happy New Year @allenporter 🍾

@frenck frenck merged commit ebc8e19 into home-assistant:dev Jan 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2022
@allenporter allenporter deleted the nest-reload branch July 9, 2022 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants