Skip to content

Update test_init.py#62535

Closed
apworks1 wants to merge 1 commit intohome-assistant:devfrom
apworks1:patch-2
Closed

Update test_init.py#62535
apworks1 wants to merge 1 commit intohome-assistant:devfrom
apworks1:patch-2

Conversation

@apworks1
Copy link
Copy Markdown

Proposed tests for PR #62528

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Proposed tests for PR #62528
@probot-home-assistant
Copy link
Copy Markdown

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (zeroconf) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck
Copy link
Copy Markdown
Member

frenck commented Dec 21, 2021

Please add the tests to the #62528 PR, so they can be ran and tested against your suggested change.

@frenck frenck closed this Dec 21, 2021
@apworks1 apworks1 deleted the patch-2 branch December 21, 2021 23:42
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants