Prevent Zeroconf Exception on truncated service type#62528
Closed
apworks1 wants to merge 2 commits intohome-assistant:devfrom
apworks1:patch-1
Closed
Prevent Zeroconf Exception on truncated service type#62528apworks1 wants to merge 2 commits intohome-assistant:devfrom apworks1:patch-1
apworks1 wants to merge 2 commits intohome-assistant:devfrom
apworks1:patch-1
Conversation
The proposed change avoids unexpected exception from Zeroconf service.
My example: currently with an Asustor NAS the "%NAS._asustor-looksgood_http._tcp.local." service appears to have a "_http._tcp.local." service_type while its actual type is "_asustor-looksgood_http._tcp.local."
This causes an exception because the ServiceInfo __init__ checks:
if not type_.endswith(service_type_name(name, strict=False)):
raise BadTypeInNameException
File "/usr/src/homeassistant/homeassistant/components/zeroconf/__init__.py", line 405, in _process_service_update
async_service_info = AsyncServiceInfo(service_type, name)
File "/usr/local/lib/python3.9/site-packages/zeroconf/_services/info.py", line 131, in __init__
raise BadTypeInNameException
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
Contributor
|
Can you add a unit test for this case? |
Tests for updated zeroconf/__init__.py Service name which contains a shorter well known service type.
Member
|
We might need to solve this upstream Some research is required |
Author
|
I have opened a Pull Request on " jstasiak / python-zeroconf" to fix browser.py so that it does not erroneously match a type which is a superstring of the type under search. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed change avoids unexpected exception from Zeroconf service.
My example: currently with an Asustor NAS the "%NAS._asustor-looksgood_http._tcp.local." service appears to have a "_http._tcp.local." service_type while its actual type is "_asustor-looksgood_http._tcp.local."
This causes an exception because the ServiceInfo init checks:
if not type_.endswith(service_type_name(name, strict=False)):
raise BadTypeInNameException
File "/usr/src/homeassistant/homeassistant/components/zeroconf/init.py", line 405, in _process_service_update
async_service_info = AsyncServiceInfo(service_type, name)
File "/usr/local/lib/python3.9/site-packages/zeroconf/_services/info.py", line 131, in init
raise BadTypeInNameException
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: