Conversation
probot-home-assistant
bot
added
code-quality
integration: vizio
small-pr
|
Hey there @raman325, mind taking a look at this pull request as it has been labeled with an integration ( |
raman325
left a comment
raman325
left a comment
There was a problem hiding this comment.
Approved with the minor change
Co-authored-by: Raman Gupta <7243222+raman325@users.noreply.github.com>
| ): vol.All( | ||
| str, | ||
| vol.Lower, | ||
| vol.Coerce(MediaPlayerDeviceClass), |
There was a problem hiding this comment.
This is a change of functionnality: it allows receiver and other future device classes
There was a problem hiding this comment.
@raman325 was this voluntary? I missed the earlier conversation when I posted this.
There was a problem hiding this comment.
no that's a good point, I missed that receiver is also a device class. @tkdrob can we revert this commit?
|
One more thing: due to the changes to config_flow => please ensure this is tested thoroughly as I am not 100% sure how the config flow reacts with the new strEnum (see #61967). |
|
It may be useful to rebase following #62363 as it impacts the way device classes are handled in the config flow. |
| if ( | ||
| config.get(CONF_APPS) is not None | ||
| and config[CONF_DEVICE_CLASS] != DEVICE_CLASS_TV | ||
| and config[CONF_DEVICE_CLASS] is not MediaPlayerDeviceClass.TV |
There was a problem hiding this comment.
Are we sure this will work? is config[CONF_DEVICE_CLASS] actually MediaPlayerDeviceClass.TV or the string?
There was a problem hiding this comment.
You're right. I'll fix that.
frenck
added
the
smash
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
This looks good to me, thanks! 👍
6 participants
Breaking change
Proposed change
Use enums in vizio
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: