Skip to content

Add preset mode eco to Generic Thermostat #61366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tygozwolle wants to merge 1 commit into from
Closed

Add preset mode eco to Generic Thermostat #61366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions homeassistant/components/generic_thermostat/climate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
HVAC_MODE_OFF,
PRESET_AWAY,
PRESET_NONE,
PRESET_ECO,
SUPPORT_PRESET_MODE,
SUPPORT_TARGET_TEMPERATURE,
)
Expand Down Expand Up @@ -65,6 +66,7 @@
CONF_KEEP_ALIVE = "keep_alive"
CONF_INITIAL_HVAC_MODE = "initial_hvac_mode"
CONF_AWAY_TEMP = "away_temp"
CONF_ECO_TEMP = "eco_temp"
CONF_PRECISION = "precision"
SUPPORT_FLAGS = SUPPORT_TARGET_TEMPERATURE

Expand All @@ -85,6 +87,7 @@
[HVAC_MODE_COOL, HVAC_MODE_HEAT, HVAC_MODE_OFF]
),
vol.Optional(CONF_AWAY_TEMP): vol.Coerce(float),
Copy link
Copy Markdown

@alexanderlindstrom alexanderlindstrom Dec 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent

vol.Optional(CONF_ECO_TEMP): vol.Coerce(float),
vol.Optional(CONF_PRECISION): vol.In(
[PRECISION_TENTHS, PRECISION_HALVES, PRECISION_WHOLE]
),
Expand All @@ -111,6 +114,7 @@ async def async_setup_platform(hass, config, async_add_entities, discovery_info=
keep_alive = config.get(CONF_KEEP_ALIVE)
initial_hvac_mode = config.get(CONF_INITIAL_HVAC_MODE)
away_temp = config.get(CONF_AWAY_TEMP)
eco_temp = config.get(CONF_ECO_TEMP)
precision = config.get(CONF_PRECISION)
unit = hass.config.units.temperature_unit
unique_id = config.get(CONF_UNIQUE_ID)
Expand All @@ -131,6 +135,7 @@ async def async_setup_platform(hass, config, async_add_entities, discovery_info=
keep_alive,
initial_hvac_mode,
away_temp,
eco_temp,
precision,
unit,
unique_id,
Expand All @@ -157,6 +162,7 @@ def __init__(
keep_alive,
initial_hvac_mode,
away_temp,
eco_temp,
precision,
unit,
unique_id,
Expand All @@ -171,7 +177,7 @@ def __init__(
self._hot_tolerance = hot_tolerance
self._keep_alive = keep_alive
self._hvac_mode = initial_hvac_mode
self._saved_target_temp = target_temp or away_temp
self._saved_target_temp = target_temp or away_temp or eco_temp
self._temp_precision = precision
if self.ac_mode:
self._hvac_list = [HVAC_MODE_COOL, HVAC_MODE_OFF]
Expand All @@ -189,8 +195,9 @@ def __init__(
self._support_flags = SUPPORT_FLAGS
if away_temp:
self._support_flags = SUPPORT_FLAGS | SUPPORT_PRESET_MODE
self._attr_preset_modes = [PRESET_NONE, PRESET_AWAY]
self._attr_preset_modes = [PRESET_NONE, PRESET_AWAY, PRESET_ECO]
else:
Copy link
Copy Markdown

@alexanderlindstrom alexanderlindstrom Dec 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty line


self._attr_preset_modes = [PRESET_NONE]
self._away_temp = away_temp

Expand Down Expand Up @@ -537,5 +544,9 @@ async def async_set_preset_mode(self, preset_mode: str):
self._attr_preset_mode = PRESET_NONE
self._target_temp = self._saved_target_temp
await self._async_control_heating(force=True)

elif self._attr_preset_mode = PRESET_ECO
Copy link
Copy Markdown

@alexanderlindstrom alexanderlindstrom Dec 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This elif is not like the others, is this correct?

self._saved_target_temp = self._target_temp
self._target_temp = self._away_temp
await self._async_control_heating(force=True)

self.async_write_ha_state()