Add preset mode eco to Generic Thermostat#61366
Closed
Tygozwolle wants to merge 1 commit intohome-assistant:devfrom
Tygozwolle:patch-1
Closed
Add preset mode eco to Generic Thermostat#61366Tygozwolle wants to merge 1 commit intohome-assistant:devfrom Tygozwolle:patch-1
Tygozwolle wants to merge 1 commit intohome-assistant:devfrom
Tygozwolle:patch-1
Conversation
add preset mode eco
Contributor
|
Hi @Tygozwolle, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
probot-home-assistant
bot
added
integration: generic_thermostat
new-feature
small-pr
Tygozwolle
changed the title
MartinHjelmare
changed the title
| self._target_temp = self._saved_target_temp | ||
| await self._async_control_heating(force=True) | ||
|
|
||
| elif self._attr_preset_mode = PRESET_ECO |
There was a problem hiding this comment.
This elif is not like the others, is this correct?
| self._support_flags = SUPPORT_FLAGS | SUPPORT_PRESET_MODE | ||
| self._attr_preset_modes = [PRESET_NONE, PRESET_AWAY] | ||
| self._attr_preset_modes = [PRESET_NONE, PRESET_AWAY, PRESET_ECO] | ||
| else: |
| @@ -85,6 +87,7 @@ | |||
| [HVAC_MODE_COOL, HVAC_MODE_HEAT, HVAC_MODE_OFF] | |||
| ), | |||
| vol.Optional(CONF_AWAY_TEMP): vol.Coerce(float), | |||
Contributor
|
Take a look at #56080, it just got approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add preset mode eco
-->
Proposed change
i added preset mode ecoType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: