Add zwave_js fan preset modes and enable them for Inovelli LZW36#60947
Add zwave_js fan preset modes and enable them for Inovelli LZW36#60947MartinHjelmare merged 13 commits intohome-assistant:devfrom mkowalchuk:inofans
Conversation
…r the Inovelli LZW36
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration ( |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
Bump. Just need someone to help test. |
|
@firstof9 Do you have an LW36 to test with? |
|
@MartinHjelmare I do. |
|
It appears to function as intended. |
|
Great! Thanks! @mkowalchuk please rebase on the latest dev branch and solve the merge conflict. |
|
Thanks. Working on merging and retesting now. |
|
Looks like you have some formatting issues, make sure to run black. |
|
Sorry for the large number of commits for the merge. My dev environment was in disarray, so I was merging in GitHub. I tested locally (albeit with my hardware) and things seem good. |
raman325
left a comment
There was a problem hiding this comment.
no worries about the commits, we squash them anyway. You don't want to see how many commits some of my PRs have 😅
Sorry for the late review on this but I hadn't actually looked this over before. Let me know if you have any questions, happy to help you get this finished out so we can merge soon 🎉
Breaking change
This will change which fan speed is selected at certain percentages for Inovelli LZW36 fan controllers. Setting the percentage to 1% will no longer enable the 'breeze' mode; that functionality is instead accessed through a preset.
Proposed change
I've gone into a bit of a rabbit hole of trying to support a bunch of different fan controllers, thinking that after PR #60517 was in, any additional controllers would be trivial. So I e-mailed a bunch of manufacturers of Z-Wave fan controllers to get specs on their controllers, and Inovelli's support team eventually got back to me with the following data for their LZW36:
0- Off
1 - Breeze mode (this will cycle through low, medium, high settings to simulate a "breeze")
2-33 - Low
34-66 - Medium
67-99 - High
Oof. I didn't think about preset modes when I did PR #59697, so supporting this fan controller requires some rework.
So this PR does the following:
Type of change
Additional information
I don't have an Inovelli LZW36, so I haven't been able to test this on the target hardware yet. I did test this with an actual fan controller by locally replacing my HS200+'s device discovery data with the LZW36's, but it's not a perfect test, since the ranges are different. If anyone with an LZW36 can help test this PR, please give it a shot and write a comment in this PR!
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: