Use configured speed ranges for HomeSeer FC200+ fan controllers in zwave_js#59697
Merged
MartinHjelmare merged 27 commits intohome-assistant:devfrom Nov 24, 2021
mkowalchuk:hsfans
Merged
Use configured speed ranges for HomeSeer FC200+ fan controllers in zwave_js#59697MartinHjelmare merged 27 commits intohome-assistant:devfrom mkowalchuk:hsfans
MartinHjelmare merged 27 commits intohome-assistant:devfrom
mkowalchuk:hsfans
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
This may change which fan speed is selected at certain percentages for the HomeSeer FC200+.
Proposed change
Update the zwave_js fan component to explicitly support the speed ranges used in the HomeSeer FC200+. This means that the percentage slider in the UI gets step-points that represent the actual speed settings on the device (either 3 step-points or 4 step-points, depending on how the device is configured).
The HomeSeer FC200+ was probably the trickiest Z-Wave fan controller to do this for, because it has a configuration setting that switches it between having 3 and 4 speeds.
ConfigurableFanSpeedDataTemplateallows the fan component to use this setting.FanSpeedDataTemplateprovides a generic interface for this, and in the future, other types of fan controllers.Fans that have not been configured with a
FanSpeedDataTemplate(and the corresponding platform hint) continue to operate as they do now, where any value from 0-100% can be selected.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: