Skip to content

Use configured speed ranges for HomeSeer FC200+ fan controllers in zwave_js#59697

Merged
MartinHjelmare merged 27 commits intohome-assistant:devfrom
mkowalchuk:hsfans
Nov 24, 2021
Merged

Use configured speed ranges for HomeSeer FC200+ fan controllers in zwave_js#59697
MartinHjelmare merged 27 commits intohome-assistant:devfrom
mkowalchuk:hsfans

Conversation

@mkowalchuk
Copy link
Copy Markdown
Contributor

@mkowalchuk mkowalchuk commented Nov 15, 2021

Breaking change

This may change which fan speed is selected at certain percentages for the HomeSeer FC200+.

Proposed change

Update the zwave_js fan component to explicitly support the speed ranges used in the HomeSeer FC200+. This means that the percentage slider in the UI gets step-points that represent the actual speed settings on the device (either 3 step-points or 4 step-points, depending on how the device is configured).

The HomeSeer FC200+ was probably the trickiest Z-Wave fan controller to do this for, because it has a configuration setting that switches it between having 3 and 4 speeds. ConfigurableFanSpeedDataTemplate allows the fan component to use this setting. FanSpeedDataTemplate provides a generic interface for this, and in the future, other types of fan controllers.

Fans that have not been configured with a FanSpeedDataTemplate (and the corresponding platform hint) continue to operate as they do now, where any value from 0-100% can be selected.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants